chenjunjiedada commented on a change in pull request #845: Add persistent IDs to partition fields URL: https://github.com/apache/incubator-iceberg/pull/845#discussion_r402890960
########## File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java ########## @@ -58,14 +58,16 @@ private transient volatile ListMultimap<Integer, PartitionField> fieldsBySourceId = null; private transient volatile Class<?>[] lazyJavaClasses = null; private transient volatile List<PartitionField> fieldList = null; + private final int lastAssignedFieldId; Review comment: Do we want to use TypeUtil::NextID? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
