rdblue commented on a change in pull request #845: Add persistent IDs to
partition fields
URL: https://github.com/apache/incubator-iceberg/pull/845#discussion_r403187322
##########
File path: api/src/main/java/org/apache/iceberg/PartitionField.java
##########
@@ -60,7 +69,7 @@ public String name() {
@Override
public String toString() {
- return name + ": " + transform + "(" + sourceId + ")";
+ return name + " (" + fieldId + "): " + transform + "(" + sourceId + ")";
Review comment:
Nit: schemas use the format `1000: ts_day`. That would be a bit cleaner than
two sets of parens.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
