rdblue commented on a change in pull request #830: Support name mapping
resolution for parquet
URL: https://github.com/apache/incubator-iceberg/pull/830#discussion_r405636232
##########
File path:
parquet/src/main/java/org/apache/iceberg/parquet/MessageTypeToType.java
##########
@@ -200,7 +200,7 @@ protected int nextId() {
return current;
}
- private int getId(org.apache.parquet.schema.Type type) {
+ protected int getId(org.apache.parquet.schema.Type type) {
Review comment:
I think it might be better to make a new visitor for this, rather than
reusing `MessageTypeToType`. That maintains independence between classes that
don't have the same purpose. It was easy before to use `MessageTypeToType`
without modification, but there's no need to do that if it is no longer easy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
