chenjunjiedada commented on issue #830: Support name mapping resolution for parquet URL: https://github.com/apache/incubator-iceberg/pull/830#issuecomment-611868767 @rdblue , The reason for passing in name mapping in row group filter is because we build metadata mapping from footer which may contain incompatible columns with passing `typeWithIds`. I removed the name mapping through a try/catch block to solve that. The original plan is to replace all ID-based `ParquetValueReader` to the name-based readers because the `NameBaseReadBuilder` builds a `ParquetValueReader` that doesn't need any schema ID. That is why I use the original file schema instead of `typeWithIds`. But there is no harm to pass a `MessageType` with IDs to build the name-based readers. so in the latest commit, I use `typeWithIds` for both ways.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
