Fokko commented on code in PR #8015:
URL: https://github.com/apache/iceberg/pull/8015#discussion_r1262616663
##########
python/pyiceberg/table/__init__.py:
##########
@@ -773,11 +779,11 @@ def plan_files(self) -> Iterable[FileScanTask]:
data_entries: List[ManifestEntry] = []
positional_delete_entries = SortedList(key=lambda entry:
entry.data_sequence_number or INITIAL_SEQUENCE_NUMBER)
- with ThreadPool() as pool:
+ with DynamicExecutor() as executor:
Review Comment:
`None` doesn't seem to work on my end:
```
export PYICEBERG_CONCURRENCY_MODE=None
python3 /tmp/vo.py
Traceback (most recent call last):
File "/tmp/vo.py", line 1, in <module>
from pyiceberg.catalog import load_catalog
File
"/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/catalog/__init__.py",
line 42, in <module>
from pyiceberg.serializers import ToOutputFile
File
"/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/serializers.py", line
26, in <module>
from pyiceberg.table.metadata import TableMetadata, TableMetadataUtil
File
"/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/table/__init__.py",
line 72, in <module>
from pyiceberg.utils.concurrent import DynamicExecutor
File
"/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/utils/concurrent.py",
line 146, in <module>
concurrency_mode = _concurrency_mode()
File
"/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/utils/concurrent.py",
line 143, in _concurrency_mode
raise ValueError(f"Invalid concurrency mode: {mode}")
ValueError: Invalid concurrency mode: None
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
