mr-brobot commented on code in PR #8015:
URL: https://github.com/apache/iceberg/pull/8015#discussion_r1262641756
##########
python/pyiceberg/table/__init__.py:
##########
@@ -773,11 +779,11 @@ def plan_files(self) -> Iterable[FileScanTask]:
data_entries: List[ManifestEntry] = []
positional_delete_entries = SortedList(key=lambda entry:
entry.data_sequence_number or INITIAL_SEQUENCE_NUMBER)
- with ThreadPool() as pool:
+ with DynamicExecutor() as executor:
Review Comment:
Apologies! I meant unset `PYICEBERG_CONCURRENCY_MODE`, which comes across as
`None` in `pyiceberg.utils.concurrent._concurrency_mode`:
```python
def _concurrency_mode() -> ConcurrencyMode:
mode = Config().config.get("concurrency-mode")
if mode is None:
return "thread"
if mode in ("thread", "process"):
return mode # type: ignore
raise ValueError(f"Invalid concurrency mode: {mode}")
```
Will add some documentation!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
