nastra commented on code in PR #7996:
URL: https://github.com/apache/iceberg/pull/7996#discussion_r1264955125
##########
aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIO.java:
##########
@@ -321,8 +320,8 @@ public void testFileIOJsonSerialization() {
String json = FileIOParser.toJson(s3FileIO);
try (FileIO deserialized = FileIOParser.fromJson(json, conf)) {
- Assert.assertTrue(deserialized instanceof S3FileIO);
- Assert.assertEquals(s3FileIO.properties(), deserialized.properties());
+ Assertions.assertThat(deserialized instanceof S3FileIO).isTrue();
+ Assertions.assertThat(deserialized).isNotSameAs(s3FileIO);
Review Comment:
```suggestion
Assertions.assertThat(deserialized.properties).isEqualTo(s3FileIO.properties();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
