nastra commented on code in PR #7996:
URL: https://github.com/apache/iceberg/pull/7996#discussion_r1264959101
##########
build.gradle:
##########
@@ -486,7 +486,7 @@ project(':iceberg-aws') {
testImplementation 'software.amazon.awssdk:iam'
testImplementation 'software.amazon.awssdk:s3control'
testImplementation project(path: ':iceberg-api', configuration:
'testArtifacts')
- testImplementation("com.adobe.testing:s3mock-junit4") {
+ testImplementation("com.adobe.testing:s3mock-junit5:2.17.0") {
Review Comment:
this should be defined in `versions.props` as
`com.adobe.testing:s3mock-junit5 = 2.17.0` and then you don't need to specify
the version number here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
