nastra commented on code in PR #8072:
URL: https://github.com/apache/iceberg/pull/8072#discussion_r1265362182
##########
.palantir/revapi.yml:
##########
@@ -743,6 +743,11 @@ acceptedBreaks:
new: "method java.util.List<org.apache.iceberg.UpdateRequirement>
org.apache.iceberg.rest.requests.UpdateTableRequest::requirements()"
justification: "Signature changed to an interface, but this is safe
because\
\ of type erasure and the original type is always returned"
+ "1.3.0":
+ org.apache.iceberg:iceberg-api:
+ - code: "java.method.addedToInterface"
+ new: "method org.apache.iceberg.ManageSnapshots
org.apache.iceberg.ManageSnapshots::createBranch(java.lang.String)"
Review Comment:
I don't think we want to break the API just by adding a new method. Rather
than breaking the API, we typically add a default implementation that throws an
UOE, similar to how it's done in `Snapshot#removedDeleteFiles`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
