ConeyLiu commented on code in PR #8072:
URL: https://github.com/apache/iceberg/pull/8072#discussion_r1280209319


##########
api/src/main/java/org/apache/iceberg/ManageSnapshots.java:
##########
@@ -83,6 +83,19 @@ public interface ManageSnapshots extends 
PendingUpdate<Snapshot> {
    */
   ManageSnapshots cherrypick(long snapshotId);
 
+  /**
+   * Create a new branch. The branch will point to current snapshot if the 
current snapshot is not
+   * NULL. Otherwise, the branch will point to a newly created empty snapshot.
+   *
+   * @param name branch name
+   * @return this for method chaining
+   * @throws IllegalArgumentException if a branch with the given name already 
exists

Review Comment:
   @rdblue I opened #8197 for a follow-up. And I am sorry for that indeed 
missed the checking.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to