aokolnychyi commented on code in PR #8123:
URL: https://github.com/apache/iceberg/pull/8123#discussion_r1270132424
##########
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##########
@@ -411,10 +439,14 @@ Builder scanMetrics(ScanMetrics newScanMetrics) {
return this;
}
- DeleteFileIndex build() {
+ private Collection<DeleteFile> planFiles() {
+ if (deleteFiles != null) {
+ return deleteFiles;
+ }
+
// read all of the matching delete manifests in parallel and accumulate
the matching files in
// a queue
- Queue<ManifestEntry<DeleteFile>> deleteEntries = new
ConcurrentLinkedQueue<>();
Review Comment:
This will be a separate PR. The goal is to make the builder use `DeleteFile`
objects directly, instead of relying on manifest entires. That way, we can
build an index using a set of files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
