aokolnychyi commented on code in PR #8123:
URL: https://github.com/apache/iceberg/pull/8123#discussion_r1270133985
##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -228,6 +228,12 @@ private TableProperties() {}
public static final String ORC_BATCH_SIZE =
"read.orc.vectorization.batch-size";
public static final int ORC_BATCH_SIZE_DEFAULT = 5000;
+ public static final String PLANNING_MODE = "read.planning-mode";
+ public static final String PLANNING_MODE_DEFAULT =
PlanningMode.AUTO.modeName();
+
+ public static final String DELETE_PLANNING_MODE =
"read.delete.planning-mode";
+ public static final String DELETE_PLANNING_MODE_DEFAULT =
PlanningMode.LOCAL.modeName();
Review Comment:
I am debating whether these configs make sense at the table level. Using
`LOCAL` for deletes by default as those are less likely to be filtered using
min/max filters and we will need to load stats so the cost of bringing them to
the driver will be higher.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
