Xuanwo commented on code in PR #6:
URL: https://github.com/apache/iceberg-rust/pull/6#discussion_r1271237053
##########
src/error.rs:
##########
@@ -0,0 +1,11 @@
+use thiserror::Error;
+
+#[derive(Error, Debug)]
+pub enum IcebergError {
Review Comment:
I perfer to have a custom error that we can have the following things:
- Error code that help users to decide how to take actions.
- Error Message that describe what happend.
- Error Context that provide more information for users.
- Error Causes that help users to figure out what happened (with backtrace
support).
I'm willing to implement this after this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]