JanKaul commented on code in PR #6:
URL: https://github.com/apache/iceberg-rust/pull/6#discussion_r1271786767
##########
src/error.rs:
##########
@@ -0,0 +1,11 @@
+use thiserror::Error;
+
+#[derive(Error, Debug)]
+pub enum IcebergError {
Review Comment:
Sorry for jumping ahead and use thiserror, it looked really convenient and
powerful at the same time. But we can also use a custom error. Just for
reference I think most of the functionality(error message, source, backtrace)
can be implemented with thiserror plus it's really convenient to impl `From`
for external Errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
