ConeyLiu commented on code in PR #8106:
URL: https://github.com/apache/iceberg/pull/8106#discussion_r1273132385


##########
core/src/main/java/org/apache/iceberg/BaseEntriesTable.java:
##########
@@ -59,6 +63,16 @@ public Schema schema() {
     return TypeUtil.join(schema, 
MetricsUtil.readableMetricsSchema(table().schema(), schema));
   }
 
+  @Override
+  public PartitionSpec spec() {
+    return specs.get(defaultSpecId);

Review Comment:
   A bit concerned here. Should the partition spec of metadata be equal to the 
table? From my understanding, the metadata tables should be definitive new 
tables. Just like we have specified schema for the metadata table.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to