ConeyLiu commented on code in PR #8106:
URL: https://github.com/apache/iceberg/pull/8106#discussion_r1274488094
##########
core/src/main/java/org/apache/iceberg/BaseEntriesTable.java:
##########
@@ -59,6 +63,16 @@ public Schema schema() {
return TypeUtil.join(schema,
MetricsUtil.readableMetricsSchema(table().schema(), schema));
}
+ @Override
+ public PartitionSpec spec() {
+ return specs.get(defaultSpecId);
Review Comment:
Yeah, I see the spec is used only for push-down in this PR. The problem is
that the spec is built with the table schema which is not the same as the
metadata table schema. This could be a little confusing for the people who used
the Java API. Could we just use the spec to do the push-down while not exposing
it for the metadata table? Not sure whether there are some better choices.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
