RussellSpitzer commented on code in PR #8042:
URL: https://github.com/apache/iceberg/pull/8042#discussion_r1274205926
##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -362,4 +362,8 @@ private TableProperties() {}
public static final String UPSERT_ENABLED = "write.upsert.enabled";
public static final boolean UPSERT_ENABLED_DEFAULT = false;
+ // Controls whether the set distribution mode has to be followed or not.
+ public static final String STRICT_TABLE_DISTRIBUTION_AND_ORDERING =
+ "strict-table-distribution-and-ordering";
+ public static final String STRICT_TABLE_DISTRIBUTION_AND_ORDERING_DEFAULT =
"true";
Review Comment:
The doc which is currently in the planning section should probably be here
instead
```
// if strict distribution mode is not enabled, then we fallback to
spark AQE
// to determine the number of partitions by colaesceing and
un-skewing partitions
// Also to note, Rebalance is only supported for hash distribution
mode till spark 3.3
// By default the strictDistributionMode is set to true, to not
disrupt regular
// plan of RepartitionByExpression
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
