aokolnychyi commented on code in PR #8042:
URL: https://github.com/apache/iceberg/pull/8042#discussion_r1277722443
##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -362,4 +362,8 @@ private TableProperties() {}
public static final String UPSERT_ENABLED = "write.upsert.enabled";
public static final boolean UPSERT_ENABLED_DEFAULT = false;
+ // Controls whether the set distribution mode has to be followed or not.
+ public static final String STRICT_TABLE_DISTRIBUTION_AND_ORDERING =
+ "strict-table-distribution-and-ordering";
+ public static final String STRICT_TABLE_DISTRIBUTION_AND_ORDERING_DEFAULT =
"true";
Review Comment:
I don't think it is a good idea to add a new public-facing table property
that is already applicable only to older versions of Spark. Can we add a SQL
property instead in our 3.3 module? Also, I would be okay skipping it and just
assuming the distribution has to be strict. Then Spark will coalesce small
files but won't split large ones.
Also, the ordering is always required. It is just the distribution that can
be strict or not. It should be reflected in the name of the property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
