rdblue commented on code in PR #8067:
URL: https://github.com/apache/iceberg/pull/8067#discussion_r1279843471
##########
python/pyiceberg/utils/schema_conversion.py:
##########
@@ -592,13 +599,13 @@ def visit_timestamp(self, timestamp_type: TimestampType)
-> AvroType:
def visit_timestamptz(self, timestamptz_type: TimestamptzType) -> AvroType:
# Iceberg only supports micro's
- return {"type": "long", "logicalType": "timestamp-micros"}
+ return {"type": "long", "logicalType": "timestamp-micros",
"adjust-to-utc": True}
Review Comment:
The spec shows that this is also explicitly set for the `timestamp` type:
`"adjust-to-utc": false`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
