Fokko commented on code in PR #8067:
URL: https://github.com/apache/iceberg/pull/8067#discussion_r1280345088
##########
python/pyiceberg/utils/schema_conversion.py:
##########
@@ -64,11 +64,11 @@
LOGICAL_FIELD_TYPE_MAPPING: Dict[Tuple[str, str], PrimitiveType] = {
("date", "int"): DateType(),
- ("time-millis", "int"): TimeType(),
+ ("time-micros", "long"): TimeType(),
Review Comment:
This isn't part of the Iceberg spec, I'd rather leave it out.
##########
python/pyiceberg/utils/schema_conversion.py:
##########
@@ -64,11 +64,11 @@
LOGICAL_FIELD_TYPE_MAPPING: Dict[Tuple[str, str], PrimitiveType] = {
("date", "int"): DateType(),
- ("time-millis", "int"): TimeType(),
+ ("time-micros", "long"): TimeType(),
Review Comment:
This isn't part of the Iceberg spec, I'd rather leave it out unless you have
strong concerns here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
