rdblue commented on a change in pull request #968:
URL: https://github.com/apache/incubator-iceberg/pull/968#discussion_r415404480
##########
File path: core/src/main/java/org/apache/iceberg/SnapshotManager.java
##########
@@ -159,6 +167,7 @@ public Snapshot apply() {
return base.snapshot(targetSnapshotId);
} else {
// validate(TableMetadata) is called in apply(TableMetadata) after
this apply refreshes the table state
+ requiresSnapshotCreation = true;
Review comment:
I think this should be set when the operation is configured, not when it
is applied.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
