rdblue commented on a change in pull request #968:
URL: https://github.com/apache/incubator-iceberg/pull/968#discussion_r415404639
##########
File path: core/src/main/java/org/apache/iceberg/SnapshotManager.java
##########
@@ -82,6 +92,7 @@ public ManageSnapshots cherrypick(long snapshotId) {
// link the snapshot about to be published on commit with the picked
snapshot
set(SnapshotSummary.SOURCE_SNAPSHOT_ID_PROP,
String.valueOf(targetSnapshotId));
} else {
+ //TODO: snapshotOperation maybe unset here.
Review comment:
Yes, because an existing snapshot is used, `operation` should not be
called.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
