RussellSpitzer commented on code in PR #8042:
URL: https://github.com/apache/iceberg/pull/8042#discussion_r1287338276
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkSQLProperties.java:
##########
@@ -63,4 +63,14 @@ private SparkSQLProperties() {}
// Controls the WAP branch used for write-audit-publish workflow.
// When set, new snapshots will be committed to this branch.
public static final String WAP_BRANCH = "spark.wap.branch";
+
+ // This property doesn't need to be transferred to Spark 3.4 because we have
already set
Review Comment:
This description seems to just describe the implementation, what we would
need here is just what an end user would need to know. What does this property
do for the user and why should they change it?
I would probably change the whole name to something like, "ENABLE_MERGE_AQE"
or something like that.
"spark.merge-aqe.enabled" defaulting to false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]