aokolnychyi commented on code in PR #8042:
URL: https://github.com/apache/iceberg/pull/8042#discussion_r1287833519
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkSQLProperties.java:
##########
@@ -63,4 +63,14 @@ private SparkSQLProperties() {}
// Controls the WAP branch used for write-audit-publish workflow.
// When set, new snapshots will be committed to this branch.
public static final String WAP_BRANCH = "spark.wap.branch";
+
+ // This property doesn't need to be transferred to Spark 3.4 because we have
already set
Review Comment:
I believe this would apply to all writes, not only row-level operations, if
extensions are enabled?
What about `spark.sql.iceberg.write-aqe.enabled` with `false` by default? I
am not sure about `write-aqe` part of it but I think it has be generic and
start with `spark.sql.iceberg` prefix.
Also, the comment is probably too specific, I agree with @RussellSpitzer it
should be for the user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
