tomtongue commented on code in PR #8227:
URL: https://github.com/apache/iceberg/pull/8227#discussion_r1288045389
##########
spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMigrateTableProcedure.java:
##########
@@ -122,6 +122,27 @@ public void testMigrateWithDropBackup() throws IOException
{
Assert.assertFalse(spark.catalog().tableExists(tableName + "_BACKUP_"));
}
+ @Test
+ public void testMigrateWithBackupTableName() throws IOException {
+ Assume.assumeTrue(catalogName.equals("spark_catalog"));
Review Comment:
This part assumes if the catalog is `spark_catalog` or not. Here,
`spark_catalog` is used (if not, the code should fail). You mean this part
should be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
