tomtongue commented on code in PR #8227: URL: https://github.com/apache/iceberg/pull/8227#discussion_r1288159003
########## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/actions/MigrateTableSparkAction.java: ########## @@ -56,10 +56,12 @@ public class MigrateTableSparkAction extends BaseTableCreationSparkAction<Migrat private final StagingTableCatalog destCatalog; private final Identifier destTableIdent; - private final Identifier backupIdent; + private Identifier backupIdent; Review Comment: I believe you mean that the final field should be kept, and un-final field should be added newly. This `backupIdent` field is only referred within this class, specifically it's referred in`doExecute` and relevant methods such as `rename`, `restore` and `drop` that are called in `doExecute`. Therefore, to keep the parameter final and to make backup table name flexible, I add method variable to each method in `doExecute`, and process the table name in `doExecute`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
