nastra commented on code in PR #7976:
URL: https://github.com/apache/iceberg/pull/7976#discussion_r1289601329
##########
core/src/test/java/org/apache/iceberg/io/TestResolvingIO.java:
##########
@@ -47,4 +63,69 @@ public void testResolvingFileIOJavaSerialization() throws
IOException, ClassNotF
FileIO roundTripSerializedFileIO =
TestHelpers.roundTripSerialize(testResolvingFileIO);
assertThat(roundTripSerializedFileIO.properties()).isEqualTo(testResolvingFileIO.properties());
}
+
+ @Test
+ public void resolveFileIOBulkDeletion() throws IOException {
+ // configure resolving fileIO
+ ResolvingFileIO resolvingFileIO = new ResolvingFileIO();
+ Configuration hadoopConf = new Configuration();
+ resolvingFileIO.setConf(hadoopConf);
+ resolvingFileIO.initialize(
+ ImmutableMap.of("io-impl", "org.apache.iceberg.hadoop.HadoopFileIO"));
+ ResolvingFileIO spy = spy(resolvingFileIO);
Review Comment:
nit: I don't think you have to create 2 variables, you could just init and
spy the first one: `ResolvingFileIO resolvingFileIO = spy(new
ResolvingFileIO());`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
