nastra commented on code in PR #7976:
URL: https://github.com/apache/iceberg/pull/7976#discussion_r1290982650
##########
core/src/test/java/org/apache/iceberg/io/TestResolvingIO.java:
##########
@@ -51,16 +61,17 @@ public void
testResolvingFileIOWithHadoopFileIOKryoSerialization() throws IOExce
resolvingFileIO.setConf(conf);
resolvingFileIO.initialize(ImmutableMap.of("k1", "v1"));
-
assertThat(resolvingFileIO.ioClass(temp.toString())).isEqualTo(HadoopFileIO.class);
- assertThat(resolvingFileIO.newInputFile(temp.toString())).isNotNull();
+
assertThat(resolvingFileIO.ioClass(tempDir.getCanonicalPath())).isEqualTo(HadoopFileIO.class);
Review Comment:
I might have missed the discussion but could you elaborate please why we
switched `temp` from `java.nio.file.Path` to `File` and why this change here is
necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
