Xuanwo commented on code in PR #29: URL: https://github.com/apache/iceberg-rust/pull/29#discussion_r1290872227
########## crates/iceberg/src/spec/mod.rs: ########## @@ -18,6 +18,10 @@ //! Spec for Iceberg. pub mod datatypes; +pub mod partition; Review Comment: How about using the following export style like: ```rust mod partition; pub partition::Partition; ``` So our users don't need to care about which mod this type lives in? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
