Xuanwo commented on code in PR #29:
URL: https://github.com/apache/iceberg-rust/pull/29#discussion_r1291054034
##########
crates/iceberg/src/spec/mod.rs:
##########
@@ -17,7 +17,20 @@
//! Spec for Iceberg.
-pub mod datatypes;
-pub mod schema;
-pub mod transform;
-pub mod values;
+mod datatypes;
+mod partition;
+mod schema;
+mod snapshot;
+mod sort;
+mod table_metadata;
+mod transform;
+mod values;
+
+pub use datatypes::{ListType, MapType, NestedField, PrimitiveType, StructType,
Type};
+pub use partition::{PartitionField, PartitionSpec};
+pub use schema::{visit_schema, visit_struct, visit_type, Schema,
SchemaVisitor};
+pub use snapshot::{Operation, Reference, Snapshot, Summary};
+pub use sort::{SortField, SortOrder};
+pub use table_metadata::TableMetadata;
+pub use transform::Transform;
+pub use values::{Literal, PrimitiveLiteral, Struct};
Review Comment:
I prefer manually controlling the exported type to avoid unexpected exports.
Additionally, we can safely use `pub struct SchemaV1` internally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
