aokolnychyi opened a new pull request, #8297:
URL: https://github.com/apache/iceberg/pull/8297
This PR removes the overflow check in `DefaultCounter`, which causes
performance issues when the counter is being accessed from multiple threads.
Prior to this PR:
```
Benchmark Mode Cnt Score
Error Units
CountersBenchmark.defaultCounterMultipleThreads ss 25 4.912 ±
0.110 s/op
CountersBenchmark.defaultCounterMultipleThreads:·async ss NaN
---
CountersBenchmark.defaultCounterSingleThread ss 25 1.136 ±
0.014 s/op
CountersBenchmark.defaultCounterSingleThread:·async ss NaN
---
```
After this PR:
```
Benchmark Mode Cnt Score
Error Units
CountersBenchmark.defaultCounterMultipleThreads ss 25 0.168 ±
0.022 s/op
CountersBenchmark.defaultCounterMultipleThreads:·async ss NaN
---
CountersBenchmark.defaultCounterSingleThread ss 25 1.134 ±
0.011 s/op
CountersBenchmark.defaultCounterSingleThread:·async ss NaN
---
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
