aokolnychyi commented on code in PR #8297:
URL: https://github.com/apache/iceberg/pull/8297#discussion_r1292666573
##########
api/src/main/java/org/apache/iceberg/metrics/DefaultCounter.java:
##########
@@ -63,7 +63,6 @@ public void increment() {
@Override
public void increment(long amount) {
- Math.addExact(counter.longValue(), amount);
Review Comment:
> since it's a public class and if someone is using it, should we mention
this in javadoc?
That's a good idea, will do if we decide to proceed with the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
