rdblue commented on code in PR #8207: URL: https://github.com/apache/iceberg/pull/8207#discussion_r1292842052
########## python/pyiceberg/io/__init__.py: ########## @@ -55,6 +55,17 @@ HDFS_PORT = "hdfs.port" HDFS_USER = "hdfs.user" HDFS_KERB_TICKET = "hdfs.kerberos_ticket" +GCS_TOKEN = "gcs.oauth2.token" +GCS_TOKEN_EXPIRES_AT = "gcs.oauth2.token-expires-at" +GCS_PROJECT_ID = "gcs.project-id" +GCS_ACCESS = "gcs.access" +GCS_CONSISTENCY = "gcs.consistency" +GCS_CACHE_TIMEOUT = "gcs.cache-timeout" +GCS_REQUESTER_PAYS = "gcs.requester-pays" +GCS_SESSION_KWARGS = "gcs.session-kwargs" +GCS_ENDPOINT_URL = "gcs.endpoint-url" +GCS_DEFAULT_LOCATION = "gcs.default-bucket-location" Review Comment: What does this control? Does it modify URIs to fill in a bucket if it isn't present? I'm not sure that's a good idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
