rdblue commented on code in PR #8207:
URL: https://github.com/apache/iceberg/pull/8207#discussion_r1292842114
##########
python/pyiceberg/io/pyarrow.py:
##########
@@ -313,6 +319,19 @@ def _get_fs(self, scheme: str) -> FileSystem:
"kerb_ticket": self.properties.get(HDFS_KERB_TICKET),
}
return HadoopFileSystem(**client_kwargs)
+ elif scheme in {"gs", "gcs"}:
+ gcs_kwargs: Dict[str, Any] = {}
+ if access_token := self.properties.get(GCS_TOKEN):
+ gcs_kwargs["access_token"] = access_token
+ if expiration := self.properties.get(GCS_TOKEN_EXPIRES_AT):
Review Comment:
If this is interpreted as ms, should the property include `-ms` at the end?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
