rdblue commented on code in PR #7782: URL: https://github.com/apache/iceberg/pull/7782#discussion_r1295070585
########## python/pyiceberg/table/metadata.py: ########## @@ -28,11 +30,11 @@ from pydantic import Field from pydantic import ValidationError as PydanticValidationError -from pydantic import root_validator +from pydantic import model_validator from typing_extensions import Annotated from pyiceberg.exceptions import ValidationError -from pyiceberg.partitioning import PartitionSpec, assign_fresh_partition_spec_ids +from pyiceberg.partitioning import PARTITION_FIELD_ID_START, PartitionSpec, assign_fresh_partition_spec_ids Review Comment: Ah, so this was needed outside of `partitioning` and that's why it is no longer prefixed with an underscore? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
