rdblue commented on code in PR #7782:
URL: https://github.com/apache/iceberg/pull/7782#discussion_r1295078597
##########
python/pyiceberg/types.py:
##########
@@ -133,32 +176,34 @@ class FixedType(PrimitiveType):
False
"""
- __root__: str = Field()
- _len: int = PrivateAttr()
+ root: int = Field()
Review Comment:
Why is the length called `root` now? Can we call it `len` or similar
instead? I think it is confusing this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
