Fokko commented on code in PR #7782:
URL: https://github.com/apache/iceberg/pull/7782#discussion_r1295103999
##########
python/pyiceberg/types.py:
##########
@@ -390,25 +446,49 @@ def __init__(
value_required: bool = True,
**data: Any,
):
- data["key_id"] = key_id or data["key-id"]
- data["key_type"] = key_type or data["key"]
- data["value_id"] = value_id or data["value-id"]
- data["value_type"] = value_type or data["value"]
- data["value_required"] = value_required if value_required is not None
else data["value_required"]
-
- data["key_field"] = NestedField(name="key", field_id=data["key_id"],
field_type=data["key_type"], required=True)
- data["value_field"] = NestedField(
- name="value", field_id=data["value_id"],
field_type=data["value_type"], required=data["value_required"]
- )
+ data["key-id"] = data["key-id"] if "key-id" in data else key_id
+ data["key"] = data["key"] if "key" in data else key_type
+ data["value-id"] = data["value-id"] if "value-id" in data else value_id
+ data["value"] = data["value"] if "value" in data else value_type
+ data["value_required"] = data["value_required"] if "value_required" in
data else value_required
Review Comment:
Yes, thank you :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
