Fokko commented on code in PR #7782:
URL: https://github.com/apache/iceberg/pull/7782#discussion_r1295091580
##########
python/pyiceberg/types.py:
##########
@@ -265,7 +311,7 @@ def __str__(self) -> str:
def __getnewargs__(self) -> Tuple[int, str, IcebergType, bool,
Optional[str]]:
"""A magic function for pickling the NestedField class."""
- return (self.field_id, self.name, self.field_type, self.required,
self.doc)
+ return self.field_id, self.name, self.field_type, self.required,
self.doc
Review Comment:
No, but my IDE was bugging me :)
##########
python/pyiceberg/table/metadata.py:
##########
@@ -28,11 +30,11 @@
from pydantic import Field
from pydantic import ValidationError as PydanticValidationError
-from pydantic import root_validator
+from pydantic import model_validator
from typing_extensions import Annotated
from pyiceberg.exceptions import ValidationError
-from pyiceberg.partitioning import PartitionSpec,
assign_fresh_partition_spec_ids
+from pyiceberg.partitioning import PARTITION_FIELD_ID_START, PartitionSpec,
assign_fresh_partition_spec_ids
Review Comment:
Exactly, the `_` means that it shouldn't be used outside of the class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
