tomtongue commented on code in PR #8227: URL: https://github.com/apache/iceberg/pull/8227#discussion_r1295345813
########## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/actions/MigrateTableSparkAction.java: ########## @@ -56,17 +56,16 @@ public class MigrateTableSparkAction extends BaseTableCreationSparkAction<Migrat private final StagingTableCatalog destCatalog; private final Identifier destTableIdent; - private final Identifier backupIdent; private boolean dropBackup = false; + private String backupTableName = ""; Review Comment: Thanks for the suggestion. The suggestion totally makes sense to me. Based on this comment, I update as follows: * revert back the `backupIdent` variable with making the var *non-final*, and the `backupIdent` initialization part * add the table change logic in the `withBackupTableName` method that is newly added in this PR * remove the `backupTableName` var along with the way to update back along with the above two changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
