tomtongue commented on code in PR #8227:
URL: https://github.com/apache/iceberg/pull/8227#discussion_r1298116227
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/actions/MigrateTableSparkAction.java:
##########
@@ -102,6 +102,14 @@ public MigrateTableSparkAction dropBackup() {
return this;
}
+ @Override
+ public MigrateTableSparkAction withBackupTableName(String tableName) {
+ if (!tableName.isEmpty()) {
Review Comment:
Thanks for the suggestion. Your suggestion is correct and I totally agree
with it. Update as follows:
* remove checking if the table name is empty, and directly set the backup
table name to `backupIdent`
* set the `sourceTableIdent` in the `backupIdent` update part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
