nastra commented on code in PR #8334:
URL: https://github.com/apache/iceberg/pull/8334#discussion_r1295877420


##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -252,4 +254,22 @@ protected void finalize() throws Throwable {
       }
     }
   }
+
+  @Override
+  public Iterable<FileInfo> listPrefix(String prefix) {
+    return withPrefixSupport(io(prefix)).listPrefix(prefix);

Review Comment:
   Technically, there could be code that checks `if (io instanceof 
SupportsPrefixOperations) { // do some prefix-related operation }` where `io` 
is of type `ResolvingFileIO` but the underlying io implementation doesn't 
support  prefix operations. We unfortunately don't have a good way to detect 
this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to