RussellSpitzer commented on code in PR #8334:
URL: https://github.com/apache/iceberg/pull/8334#discussion_r1296151043
##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -252,4 +254,22 @@ protected void finalize() throws Throwable {
}
}
}
+
+ @Override
+ public Iterable<FileInfo> listPrefix(String prefix) {
+ return withPrefixSupport(io(prefix)).listPrefix(prefix);
Review Comment:
I was worried about this on the previous PR that suggested it. We basically
force all delegates of Resolving fileIO to now support prefix operations, but
we don't actually say this anywhere. If we are going to make this change we
should have Asserts in the init method, break the rev api, properly type "io"
to return a FileIO which extends SupportsPrefix and so forth.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
