aokolnychyi commented on code in PR #8360:
URL: https://github.com/apache/iceberg/pull/8360#discussion_r1299423700
##########
core/src/main/java/org/apache/iceberg/MetricsConfig.java:
##########
@@ -92,7 +92,7 @@ public static MetricsConfig forPositionDelete(Table table) {
ImmutableMap.Builder<String, MetricsMode> columnModes =
ImmutableMap.builder();
columnModes.put(MetadataColumns.DELETE_FILE_PATH.name(),
MetricsModes.Full.get());
- columnModes.put(MetadataColumns.DELETE_FILE_POS.name(),
MetricsModes.Full.get());
+ columnModes.put(MetadataColumns.DELETE_FILE_POS.name(),
MetricsModes.Counts.get());
Review Comment:
I am debating here. These boundaries were never used anywhere, I see no
value in these during planning. I also doubt there would be any value in
readers given how we apply deletes (in theory, we could be comparing row group
positions against that but I am not sure we would ever do that given our plans
for caching). Can be convinced otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
