aokolnychyi commented on code in PR #8360:
URL: https://github.com/apache/iceberg/pull/8360#discussion_r1300739521
##########
core/src/main/java/org/apache/iceberg/deletes/PositionDeleteWriter.java:
##########
@@ -107,4 +117,13 @@ public DeleteFile toDeleteFile() {
public DeleteWriteResult result() {
return new DeleteWriteResult(toDeleteFile(), referencedDataFiles());
}
+
+ private Metrics metrics() {
+ Metrics metrics = appender.metrics();
+ if (referencedDataFiles.size() > 1) {
+ return MetricsUtil.copyWithoutFieldBounds(metrics,
SINGLE_REFERENCED_FILE_BOUNDS_ONLY);
Review Comment:
I am not aware of any engines that persist deleted rows but I opted in for
an incremental change in behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
