jerqi commented on code in PR #8346:
URL: https://github.com/apache/iceberg/pull/8346#discussion_r1300820209
##########
core/src/main/java/org/apache/iceberg/BaseFileScanTask.java:
##########
@@ -123,7 +170,19 @@ public boolean canMerge(ScanTask other) {
@Override
public SplitScanTask merge(ScanTask other) {
SplitScanTask that = (SplitScanTask) other;
- return new SplitScanTask(offset, len + that.length(), fileScanTask);
+ return new SplitScanTask(offset, len + that.length(), fileScanTask,
deletesSizeBytes);
Review Comment:
1. Should we use the method `deleteSizeBytes()` instead of the variable
`deleteSizeBytes`? Should this place be consistent with other places?
2. Should we merge the two tasks' `deletesSizeBytes` such as
`deleteSizeBytes() + that.deleteSizeBytes()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
