jerqi commented on code in PR #8346:
URL: https://github.com/apache/iceberg/pull/8346#discussion_r1301032955
##########
core/src/main/java/org/apache/iceberg/BaseFileScanTask.java:
##########
@@ -123,7 +170,19 @@ public boolean canMerge(ScanTask other) {
@Override
public SplitScanTask merge(ScanTask other) {
SplitScanTask that = (SplitScanTask) other;
- return new SplitScanTask(offset, len + that.length(), fileScanTask);
+ return new SplitScanTask(offset, len + that.length(), fileScanTask,
deletesSizeBytes);
Review Comment:
```
SplitScanTask one = xxxx;
SplitScanTask two = xxx;
SplitScanTask three = one.merge(two); // Now the variable deleteSizeBytes is
zero
three.deleteSizeBytes(); // we will compute the deleteSizeBytes
one.deleteSizeBytes(); // We will compute the deleteSizeBytes
```
It will recompute the deleteSizeBytes repeatedly in this situation. Could
you point it out if I am wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
