RussellSpitzer commented on code in PR #8334:
URL: https://github.com/apache/iceberg/pull/8334#discussion_r1303200372


##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -252,4 +254,22 @@ protected void finalize() throws Throwable {
       }
     }
   }
+
+  @Override
+  public Iterable<FileInfo> listPrefix(String prefix) {
+    return withPrefixSupport(io(prefix)).listPrefix(prefix);

Review Comment:
   I'm fine with the approach in #8169 But we need to bite the bullet. Either 
we are breaking this api and if so we should make all of our requirements 
clear. The class has to fail if it is init with a non compatible class and we 
should remove all cast's.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to