nastra commented on code in PR #8334:
URL: https://github.com/apache/iceberg/pull/8334#discussion_r1305221596
##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -213,10 +206,17 @@ FileIO io(String location) {
}
}
}
+
+ Preconditions.checkState(
Review Comment:
I'd slightly prefer the check here as it's more explicit
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopFileIO.java:
##########
@@ -48,7 +49,11 @@
import org.slf4j.LoggerFactory;
public class HadoopFileIO
- implements FileIO, HadoopConfigurable, SupportsPrefixOperations,
SupportsBulkOperations {
+ implements FileIO,
+ HadoopConfigurable,
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
