rdblue commented on code in PR #8381:
URL: https://github.com/apache/iceberg/pull/8381#discussion_r1303428449
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -124,7 +124,7 @@ static TableMetadata newTableMetadata(
MetricsConfig.fromProperties(properties).validateReferencedColumns(schema);
return new Builder()
- .upgradeFormatVersion(formatVersion)
+ .setFormatVersion(formatVersion)
Review Comment:
I think it's a bit dangerous to expose the ability to set rather than
upgrade the format version. I think people are going to call it when they
shouldn't. Is it actually needed here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
