nastra commented on code in PR #8381:
URL: https://github.com/apache/iceberg/pull/8381#discussion_r1305893289
##########
spark/v3.4/spark-runtime/src/integration/java/org/apache/iceberg/spark/SmokeTest.java:
##########
@@ -117,11 +117,7 @@ public void testAlterTable() throws NoSuchTableException {
sql("ALTER TABLE %s DROP PARTITION FIELD shard", tableName);
table = getTable();
- Assert.assertEquals("Table should have 4 partition fields", 4,
table.spec().fields().size());
- // VoidTransform is package private so we can't reach it here, just
checking name
- Assert.assertTrue(
- "All transforms should be void",
- table.spec().fields().stream().allMatch(pf ->
pf.transform().toString().equals("void")));
+ Assert.assertTrue("Table should be unpartitioned",
table.spec().isUnpartitioned());
Review Comment:
minor: I think it would be good to switch assertions to AssertJ in such a
case - the project is trying to move away from Junit4-style assertions, and it
would be great to have new assertions written using AssertJ to make the
migration process easier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
